[SE-0408] Pack iteration review feedback! #70355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simanerush
requested review from
hborla,
xedin and
slavapestov
as code owners
simanerush
force-pushed
the
pack-iteration-fixes
branch
from
a1d27c3 to
40167fb
Compare
|
@swift-ci please smoke test |
AnthonyLatsis
approved these changes
Dec 16, 2023
xedin
reviewed
Dec 18, 2023
| /// | ||
| /// \param tupleType A tuple with a single unlabeled element that represents a | ||
| /// pack expansion. | ||
| /// \param locator The locator. |
There was a problem hiding this comment.
Nit: for completeness you need to specify \returns too :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR addressing review feedback from @AnthonyLatsis in #67594
hasError()instead ofis<ErrorType>()in AST Verifier.